[ https://issues.apache.org/jira/browse/TS-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761079#comment-13761079 ]
David Carlin edited comment on TS-2168 at 9/7/13 5:30 PM: ---------------------------------------------------------- Ah, you're right.. I didn't actually read the full records.config my apologies. :( What prompted me to write this bug was that I diff'd the records.config from 3.3.5 and 4.0.1 and I saw the following: {noformat} - # The value of enable_reclaim should be 0 or 1. Default 0, reclaim disabled. + # The value of enable_reclaim should be 0 or 1. Default 1, reclaim enabled. CONFIG proxy.config.allocator.enable_reclaim INT 0 {noformat} So I was confused why someone changed the comment and not the setting. I didn't actually read the records.config, just the diff -u output and missed the big warning about --enable-reclaimable-freelist :( was (Author: dcarlin): Ah, you're right.. I didn't actually read the full records.config my apologies. :( What prompted me to write this bug was that I diff'd the records.config from 3.3.5 and 4.0.1 and I saw the following: - # The value of enable_reclaim should be 0 or 1. Default 0, reclaim disabled. + # The value of enable_reclaim should be 0 or 1. Default 1, reclaim enabled. CONFIG proxy.config.allocator.enable_reclaim INT 0 So I was confused why someone changed the comment and not the setting. I didn't actually read the records.config, just the diff -u output and missed the big warning about --enable-reclaimable-freelist :( > Confusion about proxy.config.allocator.enable_reclaim setting > ------------------------------------------------------------- > > Key: TS-2168 > URL: https://issues.apache.org/jira/browse/TS-2168 > Project: Traffic Server > Issue Type: Bug > Components: Configuration > Reporter: David Carlin > Assignee: Leif Hedstrom > Fix For: 4.1.0 > > Attachments: > 0001-TS-2168-Use-if-condition-to-control-reclaimable-free.patch > > > The default records.config in 4.0.1 says the following which is contradictory: > {noformat} > # The value of enable_reclaim should be 0 or 1. Default 1, reclaim enabled. > CONFIG proxy.config.allocator.enable_reclaim INT 0 > {noformat} > mgmt/RecordsConfig.cc shows the following: > {RECT_CONFIG, "proxy.config.allocator.enable_reclaim", RECD_INT, "1", > RECU_NULL, RR_NULL, RECC_NULL, "[0-1]", RECA_NULL} > So the default is 1, but records.config changes it to 0. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira