[
https://issues.apache.org/jira/browse/TS-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815971#comment-13815971
]
Zhao Yongming commented on TS-2082:
-----------------------------------
the next step is to remove HTTP_CACHE SPLIT_DNS and FIXME_NONMODULAR defines.
but for HTTP_CACHE, there the code is something good when you can find out
which parts is not following the origin desgin or distinct from the other
parts, it will easy the task when we need to split the big components into
small ones
> Remove NON_MODULAR #ifdef and others
> ------------------------------------
>
> Key: TS-2082
> URL: https://issues.apache.org/jira/browse/TS-2082
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Reporter: Leif Hedstrom
> Assignee: Zhao Yongming
> Labels: cleanup
> Fix For: 5.0.0
>
> Attachments: 0001-TS-2082-remove-STANDALONE_IOCORE-defines.patch,
> 0001-fix-build-with-enable-standalone-iocore.patch,
> 0002-TS-2082-remove-NON_MODULAR-define.patch
>
>
> {code}
> #if TS_HAS_STANDALONE_IOCORE
> # define STANDALONE_IOCORE 1
> #else
> # define FIXME_NONMODULAR 1
> # define SPLIT_DNS 1
> # define NON_MODULAR 1
> # define HTTP_CACHE 1
> #endif
> {code}
> all those ifdefine states relate to some work to make iocore portable to
> other project, that we don't have any interest right now.
> I think all those define should be cleanup to make codes alive, and we do not
> need to make a stand alone library right now. when we need to make the iocore
> into a library, we don't use #ifdefine.
> let us nuke them
--
This message was sent by Atlassian JIRA
(v6.1#6144)
