[ 
https://issues.apache.org/jira/browse/TS-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843347#comment-13843347
 ] 

James Peach commented on TS-2244:
---------------------------------

Hmm.

First, there's nothing here that a user cannot already do with a custom log 
format. I can see that supporting this scenario in configuration could be 
easier to use that writing a whole new log format from scratch, however.

Second, does this feature actually work as you describe? The logging 
configuration *is* hard-coded, and if you look at the way 
{{LogConfig::add_filters_to_search_log_object}} is called, the specified 
filters are applied only to the {{m_search_one}} and {{m_search_two}} formats. 
These formats already have some hard-coded filters.

The fact that there is so much being hard-coded here and that everything 
happens in the source code make me believe that, in practice, users would find 
this feature impractical. I would be very supportive of a proposal to simplify 
and document it so that it can be used by end users. As it stands, however, I 
still think this is legacy of an Inktomi UI feature and largely unusable by 
current Traffic Server users.

> remove legacy proxy.config.log.search_log_enabled feature
> ---------------------------------------------------------
>
>                 Key: TS-2244
>                 URL: https://issues.apache.org/jira/browse/TS-2244
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Cleanup, Logging
>            Reporter: James Peach
>             Fix For: 4.2.0
>
>
> While analyzing logging code, I came across the 
> {{proxy.config.log.search_log_enabled}} setting. This enabled a hard-coded 
> XML custom log format that may have been used to drive an Inktomi appliance 
> feature.
> This has never been documented and is not generally useful to modern Traffic 
> Server deployments. We should remove it.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to