[ https://issues.apache.org/jira/browse/TS-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919156#comment-13919156 ]
Leif Hedstrom edited comment on TS-2609 at 3/4/14 9:03 AM: ----------------------------------------------------------- I'm not against this patch, but I do have a question. Is this fundamentally different than doing e.g. {code} cond %{CLIENT-HEADER:Host} =www.ogre.com {code} My preference is probably to not have more than one way to achieve the same thing (*cough* Perl *cough*), but if there are good reasons to add the TOHOST directive, I'd be ok with that. Fwiw, I feel it ought to be named TO-HOST or CLIENT-HOST or even just HOST if we go this path :). Also, if you look at how we have an "adaptive" HEADER condition, a functionality like %{HOST} would similarly adapt to the hook it's in, whereas CLIENT-HOST would be anchored to the client request header. What do you think? was (Author: zwoop): I'm not against this patch, but I do have a question. Is this fundamental different than doing e.g. {code} cond %{CLIENT-HEADER:Host} =www.ogre.com {code} My preference is probably to not have more than one way to achieve the same thing (*cough* Perl *cough*), but if there are good reasons to add the TOHOST directive, I'd be ok with that. Fwiw, I feel it ought to be named TO-HOST or CLIENT-HOST or even just HOST if we go this path :). Also, if you look at how we have an "adaptive" HEADER condition, a functionality like %{HOST} would similarly adapt to the hook it's in, whereas CLIENT-HOST would be anchored to the client request header. What do you think? > Header rewrite plugin TOHOST condition > -------------------------------------- > > Key: TS-2609 > URL: https://issues.apache.org/jira/browse/TS-2609 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins > Reporter: Anil Kumar Myla > Assignee: Leif Hedstrom > Priority: Minor > Fix For: 5.0.0 > > > Enhance header rewrite plugin to support TOHOST condition. Header rewrites > conditioned on the final origin server will be supported. -- This message was sent by Atlassian JIRA (v6.2#6252)