[
https://issues.apache.org/jira/browse/TS-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931846#comment-13931846
]
James Peach commented on TS-2630:
---------------------------------
This looks pretty good. I think that types that are specific to the plugin API
(e.g. {{TSPluginRegistrationInfo}}, {{TSFetchUrlParams}}) should stay in
{{ts/ts.h}}. We don't need to do that for the first commit; that's something
that we can fine-tune over time.
It would be better to put {{ts/types.h.in}} somewhere under the iocore
directory (maybe {{iocore/api/ts/types.h.in}}) to make the separation very
clear.
> Add ts/types.h to place common types shared between API and core
> ----------------------------------------------------------------
>
> Key: TS-2630
> URL: https://issues.apache.org/jira/browse/TS-2630
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core, TS API
> Reporter: Yunkai Zhang
> Assignee: Yunkai Zhang
> Fix For: 5.0.0
>
> Attachments: 0001-TS-2630-Add-ts-types.h-to-place-common-types.patch
>
>
> ts/types.h file is used to place common types that can be shared between
> internal code and TS APIs.
> It's hard to judge what types in ts/ts.h should be migrated to ts/types.h, so
> this patch is just a beginning ...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
