[ https://issues.apache.org/jira/browse/TS-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935347#comment-13935347 ]
ASF GitHub Bot commented on TS-2553: ------------------------------------ GitHub user jablko opened a pull request: https://github.com/apache/trafficserver/pull/63 TS-2553 metalink: Fix crash if INKVConnInternal::do_io_close() gets called after a message is already complete You can merge this pull request into a Git repository by running: $ git pull https://github.com/jablko/trafficserver TS-2553 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/63.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #63 ---- commit e5c4969fe2ebb96ec8cb595ce0951d1c86ca6e04 Author: Jack Bates <j...@nottheoilrig.com> Date: 2014-03-13T18:15:35Z metalink: strcasecmp(3) says #include <strings.h> commit e9c7ff303c9e154f1dde12f139b165c244296e32 Author: Jack Bates <j...@nottheoilrig.com> Date: 2014-03-13T18:18:17Z metalink: C style casts for consistency commit ca364848ad76aabc8f3aca16ef9bc755c9e9dba3 Author: Jack Bates <j...@nottheoilrig.com> Date: 2014-03-13T18:27:18Z metalink: Give some variables better names commit e97fe577271a697627c816ed71cdc3b9c95f112e Author: Jack Bates <j...@nottheoilrig.com> Date: 2014-03-13T18:28:58Z metalink: Add missing destroy commit e233fd1c6f6ebc13b8850a8a071aa9b78e7a8cd6 Author: Jack Bates <j...@nottheoilrig.com> Date: 2014-03-13T18:57:17Z metalink: Reuse TSCacheWrite() vs. TSTransformCreate() continuation commit 5a965b1a89f2763902119f9a89e8488f3e88e713 Author: Jack Bates <j...@nottheoilrig.com> Date: 2014-03-13T19:56:53Z metalink: Handle the end of the input independently from the TS_EVENT_VCONN_WRITE_COMPLETE event from downstream commit 56b65e37b111005b204e4112dd3cd6df7361cbb7 Author: Jack Bates <j...@nottheoilrig.com> Date: 2014-03-13T20:07:53Z metalink: Plug memory leaks reported by Valgrind commit fd9a0153284978d881f0bb190e8dd95216be90e0 Author: Jack Bates <j...@nottheoilrig.com> Date: 2014-03-13T20:19:44Z metalink: Drop redundant TSUrlStringGet() commit 51c0eca079abf6361e9dbb6cd777996737166032 Author: Jack Bates <j...@nottheoilrig.com> Date: 2014-03-13T20:43:10Z metalink: Simpler to drop http.HTTPClient where not needed and minor edits commit 45393e797d69606dcb82db64acb71d61aa55a947 Author: Jack Bates <j...@nottheoilrig.com> Date: 2014-03-13T20:59:01Z TS-2553 metalink: Fix crash if INKVConnInternal::do_io_close() gets called after a message is already complete commit 850380ac3348288e81742a50ed59998c76d8275e Author: Jack Bates <j...@nottheoilrig.com> Date: 2014-03-13T21:02:19Z metalink: Send our own TS_EVENT_VCONN_WRITE_COMPLETE event upstream when the input is complete otherwise HttpSM::update_stats() won't get called and the transaction won't get logged. (If there are upstream transformations they won't get a chance to clean up otherwise!) commit c620b474b768b779ebf4e22746a2f5d00da4eb7a Author: Jack Bates <j...@nottheoilrig.com> Date: 2014-03-13T21:48:28Z metalink: Improve comments and whitespace ---- > Fix a segfault in the Metalink plugin reported by Faysal Banna and preserve > the Content-Length header > ----------------------------------------------------------------------------------------------------- > > Key: TS-2553 > URL: https://issues.apache.org/jira/browse/TS-2553 > Project: Traffic Server > Issue Type: Bug > Components: Plugins > Reporter: Jack Bates > Assignee: James Peach > Fix For: 5.0.0 > > > Fix a segfault in the Metalink plugin reported by Faysal Banna: > https://github.com/jablko/dedup/issues/1 > Copy the upstream nbytes (if known) downstream to preserve the Content-Length > header. > Improve comments in the plugin code. -- This message was sent by Atlassian JIRA (v6.2#6252)