[
https://issues.apache.org/jira/browse/TS-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987031#comment-13987031
]
Bryan Call commented on TS-2636:
--------------------------------
[~sudheerv]
These changes need to be made to the patch:
1. Indentation is 2 spaces not 4 spaces - there is a mix of indentation
2. Remove spaces at the end of lines
3. Make sure semicolons don't have a space before them - currently: "return
cond_satisfied ;"
4. Function return types need to be on a separate line - currently: void
LogAccessHttp::set_client_req_url(char *buf, int len) // STR
5. Action name should be WIPE_FIELD_VALUE - currently: const char
*LogFilter::ACTION_NAME[] = { "REJECT", "ACCEPT", "WIPE" };
6. No spaces before the parentheses in function calls - currently: wipeField
(field_value, val[i]);
Coding Style:
https://cwiki.apache.org/confluence/display/TS/Coding+Style
> Enhance ATS custom logging to support WIPE filter action
> --------------------------------------------------------
>
> Key: TS-2636
> URL: https://issues.apache.org/jira/browse/TS-2636
> Project: Traffic Server
> Issue Type: New Feature
> Components: Logging
> Reporter: Sudheer Vinukonda
> Assignee: Yunkai Zhang
> Labels: Review
> Fix For: 5.0.0
>
> Attachments: ts2636.diff
>
>
> Currently, ATS custom logging supports LogFilters with actions Accept,
> Reject. This feature request is to add a new filter action "WIPE". WIPE can
> be used in hiding sensitive parameters (e.g. userid, password) within the
> query part of a URL. Attached is a draft version of the patch. Kindly review
> and comment.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
