[ https://issues.apache.org/jira/browse/TS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000467#comment-14000467 ]
ASF subversion and git services commented on TS-2751: ----------------------------------------------------- Commit 246d3ed6cb46743c5b20c08593251ab20f90a906 in trafficserver's branch refs/heads/master from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=246d3ed ] TS-2751: fix unused variable warnings > remove ProtocolNetAccept > ------------------------ > > Key: TS-2751 > URL: https://issues.apache.org/jira/browse/TS-2751 > Project: Traffic Server > Issue Type: Bug > Components: Core, SPDY > Reporter: James Peach > Assignee: James Peach > Fix For: 5.0.0 > > > We should remove {{ProtocolNetAccept}}. {{ProtocolNetAccept}} is used to > issue an initial read request so that the leading bytes of the client session > can be snooped to detect the protocol being issued by the client. However, > I'm pretty sure that this can be implemented directly by > {{ProtocolAcceptCont}} neƩ {{ProtocolDetectSessionAccept}} using the same > technique that is used for SSL NPN and ALPN. Additionally, we should remove > the probe state from {{UnixNetVConnection}}, which we can do either by adding > a peek operation to {{NetVConnection}}, or continuing to use {{do_io_read}}, > but retaining the buffered data and passing that on to the client session > state that we subsequently spawn. -- This message was sent by Atlassian JIRA (v6.2#6252)