[ 
https://issues.apache.org/jira/browse/TS-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-3268:
------------------------------
    Issue Type: Improvement  (was: Bug)

> Superfluous #ifdef in proxy/CoreUtils.cc
> ----------------------------------------
>
>                 Key: TS-3268
>                 URL: https://issues.apache.org/jira/browse/TS-3268
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Leif Hedstrom
>             Fix For: 5.3.0
>
>
> This seems odd / wonky to me:
> {code}
> #if defined(darwin) || defined(freebsd) || defined(solaris) || 
> defined(openbsd) // FIXME: solaris x86
> // TODO: Cleanup multiple includes
> #include <stdio.h>
> #include <stdlib.h>
> #include <stdint.h>
> #include <math.h>
> #include "libts.h"
> #include "CoreUtils.h"
> #endif /* darwin || freebsd || solaris */
> {code}
> None of these seem specific to *BSD, and some are included elsewhere anyways. 
> It seems we ought to be eliminate this, or possibly, narrow down the ifdef to 
> not be platform specific (but depending on existence of include files the 
> normal autoconf way).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to