[ https://issues.apache.org/jira/browse/TS-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301566#comment-14301566 ]
ASF subversion and git services commented on TS-162: ---------------------------------------------------- Commit f47254ccd2aa62763c60855d50ae6eaccdc93aad in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=f47254c ] Updated release notes for 2.1.0 release and added TS-162 > inconsistencies in the stats system - there are incorrect assumtions on > sychronization between threads > ------------------------------------------------------------------------------------------------------ > > Key: TS-162 > URL: https://issues.apache.org/jira/browse/TS-162 > Project: Traffic Server > Issue Type: Bug > Components: Metrics > Reporter: Bryan Call > Assignee: Bryan Call > Attachments: stats_bcall_001.diff, stats_bcall_002.diff > > > There is a problem with the current stats being inconsistent. The problem is > that the net threads each have their own stats which they modify and the > aggregation thread also modifies the same stat value. There is no proper > synchronization for this to work correctly. The aggregation thread does an > atomic swap to zero the net threads stat value, but the local thread doesn't > use atomics and only increments the value. This will lead to > inconsistencies... > A better design is to *only* have the net threads modify their local stats > and have the aggregation thread handle totalling the values in a separate > stat structure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)