[
https://issues.apache.org/jira/browse/TS-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337355#comment-14337355
]
ASF GitHub Bot commented on TS-3370:
------------------------------------
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/173
TS-3370: header_rewrite plugin uses dead continuation.
I have see this in production. As far as I can tell the problem is that the
remap rules can be reloaded, leading to creating new continuations to service
those rules. 60 seconds later the old continuations are deleted. If anything is
pending long enough it can still use an old (dead) continuation.
This change reference counts the config / continuation set and destroys the
old continuations when the last reference is dropped. Note that we can't use
the standard config registration mechanism because this is structured to have a
config instance per remap rule which would overwhelm that mechanism.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-3370
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #173
----
commit 43d671b8e6bcdeee22ba795511e6e2de471b42a2
Author: Alan M. Carroll <a...@apache.org>
Date: 2015-02-25T22:27:56Z
TS-3370: header_rewrite plugin uses dead continuation.
----
> Assertion in header_rewrite plugin
> ----------------------------------
>
> Key: TS-3370
> URL: https://issues.apache.org/jira/browse/TS-3370
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Affects Versions: 5.1.2
> Reporter: daemon
> Labels: crash
> Fix For: 5.3.0
>
>
> NOTE: Traffic Server received Sig 15: Terminated
> [TrafficManager] ==> Cleaning up and reissuing signal #15
> [E. Mgmt] log ==> [TrafficManager] using root directory '/xxx/trafficserver'
> [TrafficServer] using root directory '/xxx/trafficserver'
> NOTE: Traffic Server received Sig 15: Terminated
> NOTE: Traffic Server received Sig 15: Terminated
> [E. Mgmt] log ==> [TrafficManager] using root directory '/xxx/trafficserver'
> [TrafficServer] using root directory '/xxx/trafficserver'
> FATAL: InkAPI.cc:989: failed assert `!"Plugin tries to use a continuation
> which is deleted"`
> /xxx/trafficserver/bin/traffic_server - STACK TRACE:
> /xxx/trafficserver/lib/libtsutil.so.5(+0x25be8)[0x2b67fb686be8]
> /xxx/trafficserver/lib/libtsutil.so.5(+0x23f7f)[0x2b67fb684f7f]
> /xxx/trafficserver/bin/traffic_server[0x4baec4]
> /xxx/trafficserver/bin/traffic_server(_ZN6HttpSM17state_api_calloutEiPv+0x116)[0x58a8d6]
> /xxx/trafficserver/bin/traffic_server(_ZN6HttpSM18state_api_callbackEiPv+0x8b)[0x58dc0b]
> /xxx/trafficserver/bin/traffic_server(TSHttpTxnReenable+0x45c)[0x4c338c]
> /xxx/trafficserver/libexec/trafficserver/header_rewrite.so(+0x171bd)[0x2b681421b1bd]
> /xxx/trafficserver/bin/traffic_server(_ZN6HttpSM17state_api_calloutEiPv+0x116)[0x58a8d6]
> /xxx/trafficserver/bin/traffic_server(_ZN6HttpSM33state_read_server_response_headerEiPv+0x390)[0x58f9c0]
> /xxx/trafficserver/bin/traffic_server(_ZN6HttpSM12main_handlerEiPv+0xd8)[0x58bac8]
> /xxx/trafficserver/bin/traffic_server[0x6f4b5b]
> /xxx/trafficserver/bin/traffic_server[0x6f7184]
> /xxx/trafficserver/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x1f2)[0x6ece32]
> /xxx/trafficserver/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0x8f)[0x71769f]
> /xxx/trafficserver/bin/traffic_server(_ZN7EThread7executeEv+0x493)[0x718043]
> /xxx/trafficserver/bin/traffic_server[0x716a3a]
> /lib64/libpthread.so.0(+0x79d1)[0x2b67fd2ff9d1]
> /lib64/libc.so.6(clone+0x6d)[0x2b67fe2f69dd]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
