[ https://issues.apache.org/jira/browse/TS-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358723#comment-14358723 ]
Sudheer Vinukonda commented on TS-3331: --------------------------------------- Would it be better to use the bool {{cacheable}} that is already set in the below line, instead of duplicating the header checking inside {{is_negative_caching_appropriate}}? {{https://github.com/apache/trafficserver/blob/master/proxy/http/HttpTransact.cc#L4045}} It looks like, the {{cacheable}} state calls {{is_response_cacheable}}, which seems more comprehensive than the new checks added in {{is_negative_caching_appropriate}} . > negative responses cached even when headers indicate otherwise > -------------------------------------------------------------- > > Key: TS-3331 > URL: https://issues.apache.org/jira/browse/TS-3331 > Project: Traffic Server > Issue Type: Bug > Components: Core > Reporter: William Bardwell > Assignee: William Bardwell > Labels: review > Fix For: 5.3.0 > > > Negative type status codes get cached even when there are Cache-Control: > no-store or the like headers and positive caching would be paying attention > to that. So the fix is to apply response headers (and general caching > config) to negative caching choices too. > My patch might fix [TS-2633] 406 negative responses being cached for too long -- This message was sent by Atlassian JIRA (v6.3.4#6332)