[ https://issues.apache.org/jira/browse/TS-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14369794#comment-14369794 ]
ASF GitHub Bot commented on TS-2157: ------------------------------------ Github user ericcarlschwartz commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/182#discussion_r26780107 --- Diff: proxy/http/HttpTransact.cc --- @@ -5522,7 +5527,10 @@ HttpTransact::initialize_state_variables_from_request(State* s, HTTPHdr* obsolet if (!s->server_info.name || s->redirect_info.redirect_in_process) { s->server_info.name = s->arena.str_store(host_name, host_len); - s->server_info.port = incoming_request->port_get(); + ats_ip_copy(&s->server_info.dst_addr, &s->request_data.src_ip); //initialize w/ junk + s->server_info.dst_addr.port() = incoming_request->port_get(); + ip_port_text_buffer ip_s; + DebugTxn("http_trans", "init_from_request server: %s port: %d incoming port: %d", ats_ip_nptop(&s->server_info.dst_addr.sa, ip_s, sizeof(ip_s)), s->server_info.dst_addr.port(), incoming_request->port_get()); --- End diff -- i found these additional messages in the debug logs to be very helpful but can drop them if others want them gone. > Replace "addr" with appropriate "src_addr" and "dst_addr" in > ConnectionAttributes > --------------------------------------------------------------------------------- > > Key: TS-2157 > URL: https://issues.apache.org/jira/browse/TS-2157 > Project: Traffic Server > Issue Type: New Feature > Components: Network > Reporter: Leif Hedstrom > Assignee: Eric Schwartz > Fix For: 6.0.0 > > > This would more clearly let us encapsulate the two endpoint's (IpEndpoint) > for each connection. In addition, we ought to be able to remove the "port" > member from ConnectionAttributes as well, and its convoluted and overloaded > semantics. The appropriate IpEndpoint (src_addr or dst_addr) would hold the > port information as necessary. -- This message was sent by Atlassian JIRA (v6.3.4#6332)