[ 
https://issues.apache.org/jira/browse/TS-3558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513467#comment-14513467
 ] 

Brian Geffon commented on TS-3558:
----------------------------------

I've attached a patch that will fix the issue, I will handle documentation in a 
separate commit to make backporting easier. To preemptively answer some 
questions:

- The reason {{will_be_private_ss}} is required in {{HttpSM}} is because the 
private server session variable is inside a HttpServerSession (which we don't 
have yet). Since we're trying to optimize the decision here to not attach to an 
existing session if we _know_ we're going to close it we will use this variable 
to indicate that we want to create a new server session, or if one is already 
attached that it should be marked private. Once the session is attached via 
{{HttpSM::attach_server_session}} we will set the private session variable in 
HttpServerSession.

I've made sure it's overridable via API and that it was added to the tests.

[~bcall], [~zwoop], please review.

> proxy.config.auth_server_session_private not working?
> -----------------------------------------------------
>
>                 Key: TS-3558
>                 URL: https://issues.apache.org/jira/browse/TS-3558
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: Thomas Jackson
>            Assignee: Brian Geffon
>             Fix For: 6.0.0
>
>         Attachments: share_server_session.patch
>
>
> From what I see in production (as well as in some testing-- 
> https://github.com/jacksontj/trafficserver/commit/0a0e7e946d919f29f6ac661e370971633d2602e5)
>  this option is always set to 1-- meaning I can't make an Auth'd session not 
> private. Or in otherwords irregardless of the setting the connection is 
> closed after the request-- which is bad ;)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to