[ 
https://issues.apache.org/jira/browse/TS-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035398#comment-15035398
 ] 

ASF GitHub Bot commented on TS-3072:
------------------------------------

Github user ushachar commented on the pull request:

    https://github.com/apache/trafficserver/pull/350#issuecomment-161205132
  
    To quote our own docs (under Admin Guide/Plugins):
    """
    One of the key features of Apache Traffic Server™ is its modularity. 
Features that aren’t needed in the core simply aren’t there. This helps to 
provide an additional guarantee that our core can remain fast by concentrating 
on the things that we always provide: caching and proxying.
    """
    I'd add that keeping things out of the core also makes it easier to 
understand, verify and debug.
    
    The way I see it - Logic on when to enable debugging on a 
transaction/session can be arbitrarily complex. I'm sure everyone on this 
thread can see the use of enabling debugs based on things like cipher suites, 
TLS protocol version, destination IPs. Even when relying only on source IPs, 
you might want to enable for only one in ten connections to cut the logging 
volume.
    Our (badly named :-) ) header_rewrite plugin can easily be adjusted to 
support such logic.
    (Personally - my trigger to enable debugging is often determined in an 
external process that does policy matching)
    
    @djcarlin - This being implemented in a plugin doesn't mean you'd have to 
restart ATS to use it -- The plugin would be loaded by default and you could 
enable/disable debugging by modifying it's configuration.
    (You could even talk to it directly via traffic_line using @SolidWallOfCode 
latest work on TS-4032)


> Debug logging for a single connection in production traffic.
> ------------------------------------------------------------
>
>                 Key: TS-3072
>                 URL: https://issues.apache.org/jira/browse/TS-3072
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core, Logging
>    Affects Versions: 5.0.1
>            Reporter: Sudheer Vinukonda
>            Assignee: Susan Hinrichs
>              Labels: Yahoo
>             Fix For: 6.1.0
>
>         Attachments: ts-3072.diff
>
>
> Presently, when there's a production issue (e.g. TS-3049, TS-2983 etc), it is 
> really hard to isolate/debug with the high traffic. Turning on debug logs in 
> traffic is unfortunately not an option due to performance impacts. Even if 
> you took a performance hit and turned on the logs, it is just as hard to 
> separate out the logs for a single connection/transaction among the millions 
> of the logs output in a short period of time.
> I think it would be good if there's a way to turn on debug logs in a 
> controlled manner in production environment. One simple option is to support 
> a config setting for example, with a client-ip, which when set, would turn on 
> debug logs for any connection made by just that one client. If needed, 
> instead of one client-ip, we may allow configuring up to 'n' (say, 5) 
> client-ips. 
> If there are other ideas, please comment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to