[ 
https://issues.apache.org/jira/browse/TS-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045208#comment-15045208
 ] 

ASF subversion and git services commented on TS-4047:
-----------------------------------------------------

Commit cb3d5f4eaee238e349e68bee34bde5764d94a3b0 in trafficserver's branch 
refs/heads/master from [~jaaju]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=cb3d5f4 ]

TS-4047: consistently handle multiple RPATH options

Using TS_ADDTO to add the custom locations of libraries results in
incorrect "-rpath" directive to the linker. This is because TS_ADDTO
creates a unique list of tokens that it adds to its target.

e.g. ./configure --with-openssl=/usr/local/openssl --with-zlib=/usr/local/zlib

The above results in LIBTOOL_LINK_FLAGS:
  -rpath /usr/local/openssl/lib /usr/local/zlib/lib

The absence of "-rpath" in front of the second path causes an error
in the linker. This is fixed by introducing a new macro TS_ADD_RPATH_TO
that takes a path and adds it with the "-R " prefix.

Also added the influential environmental variable RPATH that can
be used to give an additional value for the rpath.

This closes #324.


> multiple -rpath options are not handled correctly
> -------------------------------------------------
>
>                 Key: TS-4047
>                 URL: https://issues.apache.org/jira/browse/TS-4047
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build
>            Reporter: James Peach
>            Assignee: Brian Geffon
>              Labels: review
>             Fix For: 6.1.0
>
>
> https://github.com/apache/trafficserver/pull/324
> {quote}
> Using TS_ADDTO to add the custom locations of libraries results in incorrect 
> "-rpath" directive to the linker. This is because TS_ADDTO creates a unique 
> list of tokens that it adds to its target. E.g.,
> ./configure --with-openssl=/usr/local/openssl --with-zlib=/usr/local/zlib
> the above should result in
> LIBTOOL_LINK_FLAGS: -rpath /usr/local/openssl/lib /usr/local/zlib/lib
> The absence of "-rpath" in front of the second path causes an error in the 
> linker!
> This is fixed by introducing a new macro TS_ADD_RPATH_TO that takes a path 
> and adds it with the "-rpath " prefix.
> Also added influential environmental variable RPATH that can be used to give 
> a base value for the rpath. So, the following
> ./configure --with-openssl=/usr/local/openssl --with-zlib=/usr/local/zlib 
> RPATH=/foo
> will result in
> LIBTOOL_LINK_FLAGS: -rpath /foo -rpath /usr/local/zlib/lib -rpath 
> /usr/local/openssl/lib
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to