[
https://issues.apache.org/jira/browse/TS-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091380#comment-15091380
]
ASF GitHub Bot commented on TS-4112:
------------------------------------
GitHub user hnakamur opened a pull request:
https://github.com/apache/trafficserver/pull/410
Doc: [TS-4112] By default, TS caches objects with cookie including text
Please refer to https://issues.apache.org/jira/browse/TS-4112
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hnakamur/trafficserver
docs_by_default_caches_all_types_of_objects
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/410.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #410
----
commit 7c8384513fef98ba35a716ec6fc4174c9edf0ce5
Author: Hiroaki Nakamura <hnaka...@gmail.com>
Date: 2016-01-11T03:25:51Z
Doc: [TS-4112] By default, TS caches objects with cookie including text
----
> Docs: Caching Cookied Objects for any-content type
> --------------------------------------------------
>
> Key: TS-4112
> URL: https://issues.apache.org/jira/browse/TS-4112
> Project: Traffic Server
> Issue Type: Bug
> Components: Docs, Documentation
> Reporter: Hiroaki Nakamura
> Assignee: Jon Sime
> Fix For: Docs
>
>
> At
> http://trafficserver.readthedocs.org/en/latest/admin-guide/configuration/cache-basics.en.html#caching-cookied-objects
> the doc says:
> {quote}
> By default, Traffic Server caches objects served in response to requests that
> contain cookies. This is true for all types of objects except for text.
> {quote}
> However, at
> http://trafficserver.readthedocs.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-http-cache-cache-responses-to-cookies
> {quote}
> Default: 1
> 1 = cache for any content-type
> {quote}
> Also I see the default values is 1 for the config
> "proxy.config.http.cache.cache_responses_to_cookies" at the source code
> https://github.com/apache/trafficserver/blob/d197d75601772139ea489dc5686fd041dc3c257a/mgmt/RecordsConfig.cc#L643-L650
> {quote}
> // # cache responses to cookies has 4 options
> // #
> // # 0 - do not cache any responses to cookies
> // # 1 - cache for any content-type (ignore cookies)
> // # 2 - cache only for image types
> // # 3 - cache for all but text content-types
> // # 4 - cache for all but text content-types except OS response
> without "Set-Cookie" or with "Cache-Control: public"
> {RECT_CONFIG, "proxy.config.http.cache.cache_responses_to_cookies",
> RECD_INT, "1", RECU_DYNAMIC, RR_NULL, RECC_INT, "[0-4]", RECA_NULL}
> {quote}
> So we should fix the docs at
> http://trafficserver.readthedocs.org/en/latest/admin-guide/configuration/cache-basics.en.html#caching-cookied-objects
> with something like:
> By default, Traffic Server caches objects served in response to requests that
> contain cookies. This is true for all types of objects (including text
> content-type).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
