[
https://issues.apache.org/jira/browse/TS-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144010#comment-15144010
]
ASF GitHub Bot commented on TS-3917:
------------------------------------
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/466#discussion_r52704287
--- Diff: proxy/http2/HTTP2.cc ---
@@ -727,7 +727,7 @@ http2_decode_header_blocks(HTTPHdr *hdr, const uint8_t
*buf_start, const uint8_t
}
// Initialize this subsystem with librecords configs (for now)
-uint32_t Http2::max_concurrent_streams = 100;
+uint32_t Http2::max_concurrent_streams = 4294967295;
--- End diff --
This variable is override by `proxy.config.http2.max_concurrent_streams_in`
in
[Http2::init()](https://github.com/apache/trafficserver/blob/master/proxy/http2/HTTP2.cc#L743).
IMO, where we should change is `HTTP2_MAX_CONCURRENT_STREAMS` in
[HTTP2.h#L57](https://github.com/apache/trafficserver/blob/master/proxy/http2/HTTP2.h#L57)
> Sending only SETTINGS_INITIAL_WINDOW_SIZE in SETTINGS Frame
> -----------------------------------------------------------
>
> Key: TS-3917
> URL: https://issues.apache.org/jira/browse/TS-3917
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
> Reporter: Masaori Koshiba
> Assignee: Bryan Call
> Priority: Critical
> Fix For: 6.2.0
>
>
> After fix for TS-3492, ATS sends only {{SETTINGS_INITIAL_WINDOW_SIZE}} in
> first SETTINGS Frame.
> ATS should send SETTINGS Parameters when values in records.config is
> different from default value of RFC7540 (6.5.2 Defined SETTINGS Parameters).
> For example, {{SETTINGS_MAX_CONCURRENT_STREAMS}} is unlimited in RFC7540, but
> default value in records.config is 100. ATS should send this value in first
> SETTINGS Frame but not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
