[
https://issues.apache.org/jira/browse/TS-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248106#comment-15248106
]
ASF GitHub Bot commented on TS-4364:
------------------------------------
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/584
TS-4364: Address remnants from HTTP/2 refactoring
Add back in support for HttpSM->plugin_tag to enable protocol logging and
fix for TS-3954
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-4364
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/584.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #584
----
commit b89c2e1dd4b4fb7453f95361c96ea2aa7ac9a27a
Author: shinrich <[email protected]>
Date: 2016-04-19T14:40:20Z
TS-4364: Address remnants from HTTP/2 refactoring
----
> Remove some remnants from http/2 refactoring
> --------------------------------------------
>
> Key: TS-4364
> URL: https://issues.apache.org/jira/browse/TS-4364
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
> Reporter: Leif Hedstrom
> Assignee: Susan Hinrichs
> Labels: newbie++
> Fix For: 7.0.0
>
>
> It seems this code is no longer applicable, and we should remove it for
> clarity. It can wait until 7.0.0 though.
> {code}
> HttpTransact::handle_response_keep_alive_headers(State *s, HTTPVersion ver,
> HTTPHdr *heads)
> {
> .
> .
> .
> // check that the client is HTTP 1.1 and the conf allows chunking
> if (s->client_info.http_version == HTTPVersion(1, 1) &&
> (s->txn_conf->chunking_enabled == 1 ||
> (s->state_machine->plugin_tag &&
> (!strcmp(s->state_machine->plugin_tag, "http/2") ||
> !strncmp(s->state_machine->plugin_tag, "spdy", 4)))) &&
> // if we're not sending a body, don't set a chunked header regardless
> of server response
> !is_response_body_precluded(s->hdr_info.client_response.status_get(),
> s->method) &&
> // we do not need chunked encoding for internal error messages
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
