[ 
https://issues.apache.org/jira/browse/TS-3922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251154#comment-15251154
 ] 

ASF GitHub Bot commented on TS-3922:
------------------------------------

Github user bgaff commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/590#discussion_r60519710
  
    --- Diff: iocore/net/UnixNet.cc ---
    @@ -96,8 +97,8 @@ class InactivityCop : public Continuation
               NET_SUM_DYN_STAT(keep_alive_queue_timeout_total_stat, diff);
               NET_INCREMENT_DYN_STAT(keep_alive_queue_timeout_count_stat);
             }
    -        Debug("inactivity_cop_verbose", "vc: %p now: %" PRId64 " timeout 
at: %" PRId64 " timeout in: %" PRId64, vc, now,
    -              vc->next_inactivity_timeout_at, vc->inactivity_timeout_in);
    +        Debug("inactivity_cop_verbose_2", "vc: %p now: %" PRId64 " timeout 
at: %" PRId64 " timeout in: %" PRId64, vc,
    --- End diff --
    
    I just realized that in the patch I pasted in TS-3922 I left this debug tag 
name changed as inactivity_cop_verbose_2, @zizhong can you please correct that 
for me.


> Add independent WebSocket timeouts
> ----------------------------------
>
>                 Key: TS-3922
>                 URL: https://issues.apache.org/jira/browse/TS-3922
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Brian Geffon
>            Assignee: Brian Geffon
>             Fix For: 7.0.0
>
>
> Right now WebSockets fall under the active/inactive transaction timeouts. 
> Obviously the inactivate timeout isn't a problem but the active timeout is. 
> We need at minimum a new timeout for active WS connections, I'll likely add a 
> new timeout for inactive state too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to