[
https://issues.apache.org/jira/browse/TS-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298495#comment-15298495
]
ASF GitHub Bot commented on TS-4108:
------------------------------------
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/661
> SSL metrics have wrong data type
> --------------------------------
>
> Key: TS-4108
> URL: https://issues.apache.org/jira/browse/TS-4108
> Project: Traffic Server
> Issue Type: Bug
> Components: Metrics
> Reporter: James Peach
> Labels: newbie
> Fix For: sometime
>
>
> All the SSL metrics registered in {{SSLUtils.cc}} are specified as
> {{RECD_INT}}, but they are all actually counters and should be specified as
> {{RECD_COUNTER}}.
> The sync function is sometimes given as {{RecRawStatSyncSum}} and sometimes
> {{RecRawStatSyncCount}}. Although these functions are identical, we should
> choose just one.
> Note that the SSL session cache metrics are a little quirky. They *are*
> actually counters, but they use {{SSL_SET_COUNT_DYN_STAT}} rather than
> {{SSL_INCREMENT_DYN_STAT}}. AFAICT the right way to do this would be to use
> {{SSL_INCREMENT_DYN_STAT}} but clear the {{SSL_CTX}} counters on every pass.
> The way it is done now seems like it would lead to incorrect values when the
> session cache is cleared or SSL state is reloaded. Unfortunately I don't see
> an OpenSSL API to clear the counters, so more research is needed there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
