[
https://issues.apache.org/jira/browse/TS-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302485#comment-15302485
]
ASF GitHub Bot commented on TS-4461:
------------------------------------
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/669#discussion_r64783870
--- Diff: proxy/http/Http1ClientSession.cc ---
@@ -427,9 +427,12 @@ Http1ClientSession::release(ProxyClientTransaction
*trans)
ka_vio = this->do_io_read(this, INT64_MAX, read_buffer);
ink_assert(slave_ka_vio != ka_vio);
- // Y!?
- // client_vc->add_to_keep_alive_lru();
- client_vc->cancel_active_timeout();
+ if (client_vc) {
+ client_vc->add_to_keep_alive_queue();
+ if (client_vc) {
--- End diff --
Susan had to explain this to me because I'm kind of slow but I think it
might be good to have a comment about why `client_vc` needs to be checked again.
> Not closing client connections
> ------------------------------
>
> Key: TS-4461
> URL: https://issues.apache.org/jira/browse/TS-4461
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Affects Versions: 6.2.0
> Reporter: Bryan Call
> Assignee: Susan Hinrichs
> Priority: Blocker
> Fix For: 7.0.0
>
>
> Looks like we are not closing client connections correctly on the 6.2.x
> branch. After taking a server our of rotation for awhile.
> {code}
> [bcall@l28 ~]$ ss -s
> Total: 18212 (kernel 18329)
> TCP: 18122 (estab 17141, closed 123, orphaned 4, synrecv 0, timewait
> 123/0), ports 152
> {code}
> in traffic top:
> {code}
> CLIENT ORIGIN SERVER
> Requests 1.8 Head Bytes 492.0 Requests 1.8 Head Bytes 345.7
> Req/Conn 1.0 Body Bytes 0.0 Req/Conn 1.0 Body Bytes 0.0
> New Conn 1.8 Avg Size 269.0 New Conn 1.8 Avg Size 189.0
> Curr Conn 0.0 Net (bits) 3.9K Curr Conn 0.0 Net (bits)
> 2.8K
> Active Con 6.6M Resp (ms) 0.8
> Dynamic KA 0.0
> {code}
> Looks like it is happening on the client connections to TLS ports (ip of the
> server removed):
> {code}
> [bcall@l28 ~]$ ss -tn | grep 'XXX:44[3-4]' | wc -l
> 12434
> {code}
> And not on the non-TLS ports
> {code}
> [bcall@l28 ~]$ ss -tn | grep 'XXX:8' | wc -l
> 0
> {code}
> Count of the fd for the traffic_server process:
> {code}
> [bcall@l28 ~]$ sudo ls -l /proc/$(pidof traffic_server)/fd | wc -l
> 18127
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
