[
https://issues.apache.org/jira/browse/TS-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15347029#comment-15347029
]
ASF GitHub Bot commented on TS-4449:
------------------------------------
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/735#discussion_r68299556
--- Diff: plugins/header_rewrite/conditions.cc ---
@@ -86,9 +86,8 @@ ConditionMethod::eval(const Resources &res)
std::string s;
append_value(s, res);
- bool rval = static_cast<const Matchers<std::string>
*>(_matcher)->test(s);
- TSDebug(PLUGIN_NAME, "Evaluating METHOD(): %s - rval: %d", s.c_str(),
rval);
- return rval;
+ TSDebug(PLUGIN_NAME, "Evaluating METHOD()");
--- End diff --
Why did you drop the value from this debug message? The one below in
``ConditionHeader`` still has it ...
> header_rewrite: Improve TSDebug() statements
> --------------------------------------------
>
> Key: TS-4449
> URL: https://issues.apache.org/jira/browse/TS-4449
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>
> Right now, it can be difficult at times to understand why header_rewrite
> isn't behaving as you'd expect. There are a number of places where we can
> improve TSDebug().
> Also, I'm going to do a code cleanup here, to make the code more inline with
> our current best practices (e.g. use if () { } consistently).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
