[ https://issues.apache.org/jira/browse/TS-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353150#comment-15353150 ]
ASF GitHub Bot commented on TS-4590: ------------------------------------ Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/752 My main question is about the removal of handle_event. The other changes to clean up look good. > INKVConnInternal didn't set m_free_magic to DEAD as INKContInternal > ------------------------------------------------------------------- > > Key: TS-4590 > URL: https://issues.apache.org/jira/browse/TS-4590 > Project: Traffic Server > Issue Type: Improvement > Components: TS API > Reporter: Oknet Xu > > The class INKContInternal is a base class of INKVConnInternal. > INKVConnInternal rewrite destroy() and handle_event(), but forgot to set > m_free_magic to DEAD that is a debug flag. > I will add 2 methods for INKContInternal and INKVConnInternal: > - clear() > - clear variables > - free() > - call clear() first > - call this->mutex.clear(); > - set m_free_magic > - call xxxAllocator.free(this) > and rewrite destroy to call free(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)