Github user jpeach commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/779#discussion_r71102843
  
    --- Diff: plugins/experimental/ts_lua/ts_lua_http.c ---
    @@ -29,8 +29,36 @@ typedef enum {
       TS_LUA_CACHE_LOOKUP_SKIPPED
     } TSLuaCacheLookupResult;
     
    -char *ts_lua_cache_lookup_result_string[] = {"TS_LUA_CACHE_LOOKUP_MISS", 
"TS_LUA_CACHE_LOOKUP_HIT_STALE",
    -                                             
"TS_LUA_CACHE_LOOKUP_HIT_FRESH", "TS_LUA_CACHE_LOOKUP_SKIPPED"};
    +typedef enum {
    +  TS_LUA_SRVSTATE_STATE_UNDEFINED,
    +  TS_LUA_SRVSTATE_ACTIVE_TIMEOUT,
    +  TS_LUA_SRVSTATE_BAD_INCOMING_RESPONSE,
    +  TS_LUA_SRVSTATE_CONNECTION_ALIVE,
    +  TS_LUA_SRVSTATE_CONNECTION_CLOSED,
    +  TS_LUA_SRVSTATE_CONNECTION_ERROR,
    +  TS_LUA_SRVSTATE_INACTIVE_TIMEOUT,
    +  TS_LUA_SRVSTATE_OPEN_RAW_ERROR,
    +  TS_LUA_SRVSTATE_PARSE_ERROR,
    +  TS_LUA_SRVSTATE_TRANSACTION_COMPLETE,
    +  TS_LUA_SRVSTATE_CONGEST_CONTROL_CONGESTED_ON_F,
    +  TS_LUA_SRVSTATE_CONGEST_CONTROL_CONGESTED_ON_M
    +} TSLuaServerState;
    +
    +const char *ts_lua_cache_lookup_result_string[] = 
{"TS_LUA_CACHE_LOOKUP_MISS", "TS_LUA_CACHE_LOOKUP_HIT_STALE",
    +                                                   
"TS_LUA_CACHE_LOOKUP_HIT_FRESH", "TS_LUA_CACHE_LOOKUP_SKIPPED"};
    +
    +const char *ts_lua_server_state_string[] = 
{"TS_LUA_SRVSTATE_STATE_UNDEFINED",
    +                                            
"TS_LUA_SRVSTATE_ACTIVE_TIMEOUT",
    +                                            
"TS_LUA_SRVSTATE_BAD_INCOMING_RESPONSE",
    +                                            
"TS_LUA_SRVSTATE_CONNECTION_ALIVE",
    +                                            
"TS_LUA_SRVSTATE_CONNECTION_CLOSED",
    +                                            
"TS_LUA_SRVSTATE_CONNECTION_ERROR",
    +                                            
"TS_LUA_SRVSTATE_INACTIVE_TIMEOUT",
    +                                            
"TS_LUA_SRVSTATE_OPEN_RAW_ERROR",
    +                                            "TS_LUA_SRVSTATE_PARSE_ERROR",
    +                                            
"TS_LUA_SRVSTATE_TRANSACTION_COMPLETE",
    +                                            
"TS_LUA_SRVSTATE_CONGEST_CONTROL_CONGESTED_ON_F",
    +                                            
"TS_LUA_SRVSTATE_CONGEST_CONTROL_CONGESTED_ON_M"};
    --- End diff --
    
    Try putting a ',' after the last element to get clang-format to be sensible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to