[
https://issues.apache.org/jira/browse/TS-4612?focusedWorklogId=25677&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25677
]
ASF GitHub Bot logged work on TS-4612:
--------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/16 08:34
Start Date: 19/Jul/16 08:34
Worklog Time Spent: 10m
Work Description: Github user bryancall commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/771#discussion_r71292554
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -1304,9 +1305,10 @@ UnixNetVConnection::connectUp(EThread *t, int fd)
SET_HANDLER(&UnixNetVConnection::mainEvent);
nh = get_NetHandler(t);
+ set_inactivity_timeout(0);
nh->open_list.enqueue(this);
- ink_assert(!inactivity_timeout_in);
+ // ink_assert(!inactivity_timeout_in);
--- End diff --
This can be removed.
Issue Time Tracking
-------------------
Worklog Id: (was: 25677)
Time Spent: 10m
Remaining Estimate: 0h
> Proposal: InactivityCop Optimize
> --------------------------------
>
> Key: TS-4612
> URL: https://issues.apache.org/jira/browse/TS-4612
> Project: Traffic Server
> Issue Type: Bug
> Components: Core, Network
> Reporter: Oknet Xu
> Fix For: sometime
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> By review the processing of InactivityCop::check_inactivity():
> 1. get all local vc from open_list
> 2. put them into cop_list
> 3. check every vc in cop_list if it is already timeouted
> 4. callback vc->handleEvent to close vc if it is timeout
> InactivityCop and NetHandler share one mutex.
> InactivityCop runs every second, NetHandler runs every 10ms, that means
> Nethandler runs 100 times until next InactivityCop runs.
> if one vc has read/write in a Nethandler call, it is won't be timeout in the
> next InactivityCop run.
> Thus, if the vc has read/write in Nethandler, we move it out of cop-list then
> the InactivityCop runs would get better performace.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
