[ 
https://issues.apache.org/jira/browse/TS-4703?focusedWorklogId=26038&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26038
 ]

ASF GitHub Bot logged work on TS-4703:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Jul/16 02:50
            Start Date: 28/Jul/16 02:50
    Worklog Time Spent: 10m 
      Work Description: Github user zwoop commented on a diff in the pull 
request:

    https://github.com/apache/trafficserver/pull/829#discussion_r72558333
  
    --- Diff: 
doc/developer-guide/api/functions/TSHttpTxnClientProtocolGet.en.rst ---
    @@ -0,0 +1,34 @@
    +.. Licensed to the Apache Software Foundation (ASF) under one or more
    +   contributor license agreements.  See the NOTICE file distributed
    +   with this work for additional information regarding copyright
    +   ownership.  The ASF licenses this file to you under the Apache
    +   License, Version 2.0 (the "License"); you may not use this file
    +   except in compliance with the License.  You may obtain a copy of
    +   the License at
    +
    +   http://www.apache.org/licenses/LICENSE-2.0
    +
    +   Unless required by applicable law or agreed to in writing, software
    +   distributed under the License is distributed on an "AS IS" BASIS,
    +   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
    +   implied.  See the License for the specific language governing
    +   permissions and limitations under the License.
    +
    +.. include:: ../../../common.defs
    +
    +.. default-domain:: c
    +
    +TSHttpTxnClientProtocolGet
    +*********************
    +
    +Gets the protocol string (http, http/2) of a specified transaction. 
    +
    +Synopsis
    +========
    +
    +`#include <ts/ts.h>`
    +
    +.. function:: const char * TSHttpTxnClientProtocolGet(TSHttpTxn txnp)
    +
    +Description
    +===========
    --- End diff --
    
    I wonder if we should bake this docs section into 
./doc/developer-guide/api/functions/TSHttpTxnClientReqGet.en.rst ? We have too 
many man files already, and the intent was always to group API functions that 
are related into one file.
    
    I'm not 100% TSHttpTxnClientProtocolGet belongs in that particular file 
above, but maybe you can take a look and see what, if any, APIs should be 
merged together? (Feel free to coalesce other files as well :).


Issue Time Tracking
-------------------

    Worklog Id:     (was: 26038)
    Time Spent: 50m  (was: 40m)

> Adds an API call to retrieve transaction protocol
> -------------------------------------------------
>
>                 Key: TS-4703
>                 URL: https://issues.apache.org/jira/browse/TS-4703
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: TS API
>            Reporter: Petar Penkov
>             Fix For: 7.0.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> It would be useful if there was a way to retrieve the underlying protocol for 
> a given transaction through the tsapi at the very least for plugin logging 
> purposes. This can be achieved with a very simple method since this 
> information is already available internally. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to