Github user shinrich commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/831#discussion_r73763348
  
    --- Diff: proxy/logging/LogCollationClientSM.cc ---
    @@ -266,6 +266,9 @@ LogCollationClientSM::client_auth(int event, VIO * /* 
vio ATS_UNUSED */)
     
         return client_send(LOG_COLL_EVENT_SWITCH, NULL);
     
    +  case VC_EVENT_INACTIVITY_TIMEOUT:
    +    Debug("log-coll", "[%d]client::client_auth - Ignoring 
VC_EVENT_INACTIVITY_TIMEOUT", m_id);
    +    return EVENT_CONT;
    --- End diff --
    
    Is there a reason that you don't do the actions of the other terminal cases 
(EOS and ERROR)?
    
    Also, should you through VC_EVENT_ACTIVE_TIMEOUT in here while you are at 
it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to