[ 
https://issues.apache.org/jira/browse/TS-4749?focusedWorklogId=26657&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26657
 ]

ASF GitHub Bot logged work on TS-4749:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Aug/16 15:59
            Start Date: 19/Aug/16 15:59
    Worklog Time Spent: 10m 
      Work Description: Github user bryancall commented on a diff in the pull 
request:

    https://github.com/apache/trafficserver/pull/856#discussion_r75507271
  
    --- Diff: proxy/http/HttpSM.cc ---
    @@ -4865,12 +4865,13 @@ HttpSM::do_http_server_open(bool raw)
         md5_ctx.hash_immediate(hostname_hash, static_cast<const void 
*>(t_state.current.server->name),
                                strlen(t_state.current.server->name));
     
    -    ip_port_text_buffer addrbuf;
         if (connections->getCount(t_state.current.server->dst_addr, 
hostname_hash,
                                   
(TSServerSessionSharingMatchType)t_state.txn_conf->server_session_sharing_match)
 >=
             t_state.txn_conf->origin_max_connections) {
    -      DebugSM("http", "[%" PRId64 "] over the number of connection for 
this host: %s", sm_id,
    -              ats_ip_nptop(&t_state.current.server->dst_addr.sa, addrbuf, 
sizeof(addrbuf)));
    +      ip_port_text_buffer addrbuf;
    +      ats_ip_ntop(&t_state.current.server->dst_addr.sa, addrbuf, 
sizeof(addrbuf));
    --- End diff --
    
    You would want to call `ats_ip_nptop`.  `ats_ip_ntop` will only copy the 
address.


Issue Time Tracking
-------------------

    Worklog Id:     (was: 26657)
    Time Spent: 1h 10m  (was: 1h)

> Generate Warning message when origin_max_connections limit is passed
> --------------------------------------------------------------------
>
>                 Key: TS-4749
>                 URL: https://issues.apache.org/jira/browse/TS-4749
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Susan Hinrichs
>            Assignee: Susan Hinrichs
>             Fix For: 7.0.0
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Help ops debug when ATS gets into an overwhelmed state.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to