Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/965#discussion_r77540321
--- Diff: iocore/eventsystem/I_Lock.h ---
@@ -28,7 +28,7 @@
#include "ts/Diags.h"
#include "I_Thread.h"
-#define MAX_LOCK_TIME HRTIME_MSECONDS(200)
+static const ts_microseconds MAX_LOCK_TIME(200);
--- End diff --
This could also be
{{code}}
static const ts_nanoseconds MAX_LOCK_TIME(ts_microseconds(200));
{{code}}
That style is used elsewhere, I'm not sure which is better. Denoting this
value in nanoseconds avoids conversions later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
