[ https://issues.apache.org/jira/browse/TS-4532?focusedWorklogId=28119&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28119 ]
ASF GitHub Bot logged work on TS-4532: -------------------------------------- Author: ASF GitHub Bot Created on: 05/Sep/16 16:05 Start Date: 05/Sep/16 16:05 Worklog Time Spent: 10m Work Description: Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/965#discussion_r77540321 --- Diff: iocore/eventsystem/I_Lock.h --- @@ -28,7 +28,7 @@ #include "ts/Diags.h" #include "I_Thread.h" -#define MAX_LOCK_TIME HRTIME_MSECONDS(200) +static const ts_microseconds MAX_LOCK_TIME(200); --- End diff -- This could also be {{code}} static const ts_nanoseconds MAX_LOCK_TIME(ts_microseconds(200)); {{code}} That style is used elsewhere, I'm not sure which is better. Denoting this value in nanoseconds avoids conversions later. Issue Time Tracking ------------------- Worklog Id: (was: 28119) Time Spent: 40m (was: 0.5h) > Static type checking for time units > ----------------------------------- > > Key: TS-4532 > URL: https://issues.apache.org/jira/browse/TS-4532 > Project: Traffic Server > Issue Type: Improvement > Components: Core > Reporter: James Peach > Assignee: Alan M. Carroll > Fix For: 7.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Since the various time units {{ink_time_t}}, {{time_t}}, {{ink_hrtime}} are > all typedefs of C integral types, it is very hard to ensure that units are > being converted and compared correctly. > Consider wrapping these in trivial classes as part of making the time APIs > more straightforward. Alternatively, if we move to {{C++11}} investigate > {{std::chrono}} for this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)