[ 
https://issues.apache.org/jira/browse/TS-4769?focusedWorklogId=28254&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28254
 ]

ASF GitHub Bot logged work on TS-4769:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Sep/16 02:42
            Start Date: 07/Sep/16 02:42
    Worklog Time Spent: 10m 
      Work Description: GitHub user shinrich opened a pull request:

    https://github.com/apache/trafficserver/pull/975

    TS-4769: TSSslServerContextCreate always returns null

    Activated the regression test created by @jpeach.
    
    @biilmann let me know if this PR works for you.  Basically used the 
sslMultCertSettings argument as a indicator of whether we expected 
SSLInitServerContext to be a fully specified context at the end or not.
    
    The volume of changes looks worse in the diff than reality.  Most of the 
changes in SSLInitServerContext are indentation changes.  I add an outer check 
on whether sslMultCertSettings is NULL or not.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shinrich/trafficserver ts-4769

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/975.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #975
    
----

----


Issue Time Tracking
-------------------

    Worklog Id:     (was: 28254)
    Time Spent: 0.5h  (was: 20m)

> TSSslServerContextCreate always returns null
> --------------------------------------------
>
>                 Key: TS-4769
>                 URL: https://issues.apache.org/jira/browse/TS-4769
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: SSL, TS API
>            Reporter: Mathias Biilmann Christensen
>            Assignee: Susan Hinrichs
>            Priority: Blocker
>             Fix For: 7.0.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The change to SSLInitServerContext in 
> https://github.com/apache/trafficserver/pull/810 breaks the 
> TSSslServerContextCreate API method, since this one calls 
> TSSslServerContextCreate with an empty sslMultCertSettings.
> This means plugins can't create a fresh SSL context and set the certificates 
> themselves.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to