Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/947
I'm worried by the number of changes here. Has this been tested? What is
the risk of regression? Is this known to work on any platform other than Linux?
Can we add comments to describe why this is the right approach?
I note that ``NetState::error`` is not initialized, which doesn't give me a
good feeling :-/
Why do you set ``err`` to be the ``getsockopt`` failure? In most APIs you
already had the err at close time.
Why is ``NetState::error`` never cleared before doing any I/O?
Is the real fix here the fact that errors can trigger a read even when
reads are not enabled? What are the consequences of that? If that is the core
fix, then I expect we could simplify this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
