[ 
https://issues.apache.org/jira/browse/TS-4731?focusedWorklogId=28583&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28583
 ]

ASF GitHub Bot logged work on TS-4731:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Sep/16 15:12
            Start Date: 09/Sep/16 15:12
    Worklog Time Spent: 10m 
      Work Description: Github user jpeach commented on a diff in the pull 
request:

    https://github.com/apache/trafficserver/pull/995#discussion_r78197044
  
    --- Diff: doc/developer-guide/api/functions/TSHttpTxnIsInternal.en.rst ---
    @@ -41,8 +41,8 @@ was originated within Traffic Server.
     Return Values
     =============
     
    -Both these APIs returns a :type:`TSReturnCode`, indicating whether the
    -object was internal (:data:`TS_SUCCESS`) or not (:data:`TS_ERROR`).
    +Both these APIs returns a :type:`int`, indicating whether the
    +object was internal (:data:`1`) or not (:data:`0`).
    --- End diff --
    
    s/object/transaction/


Issue Time Tracking
-------------------

    Worklog Id:     (was: 28583)
    Time Spent: 1h  (was: 50m)

> Change return type for TSHttpTxnIsInternal and TSHttpSsnIsInternal
> ------------------------------------------------------------------
>
>                 Key: TS-4731
>                 URL: https://issues.apache.org/jira/browse/TS-4731
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: TS API
>            Reporter: Leif Hedstrom
>            Assignee: Leif Hedstrom
>              Labels: incompatible
>             Fix For: 7.0.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> I'd like to propose that we modify these two APIs from:
> {code}
> tsapi TSReturnCode TSHttpTxnIsInternal(TSHttpTxn txnp);
> tsapi TSReturnCode TSHttpSsnIsInternal(TSHttpSsn snap);
> {code}
> to be
> {code}
> tsapi int TSHttpTxnIsInternal(TSHttpTxn txnp);
> tsapi int TSHttpSsnIsInternal(TSHttpSsn snap);
> {code}
> This is more inline with our current standards of using "int" as a boolean 
> type. This is for example the prototype in TSVConnIsSsl() as well as in e.g. 
> TSHttpTxnDebugSet(TSHttpTxn txnp, int on).
> This is an incompatible change though.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to