Github user jpeach commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/990#discussion_r78202428
  
    --- Diff: iocore/net/SSLUtils.cc ---
    @@ -1866,10 +1934,17 @@ ssl_store_ssl_context(const SSLConfigParams 
*params, SSLCertLookup *lookup, cons
         keyblock = ssl_context_enable_tickets(ctx, NULL);
       }
     
    +  // Generate HPKP header if hpkp is enabled.
    +  if (sslMultCertSettings.hpkp_enabled >= 0 ? 
sslMultCertSettings.hpkp_enabled : params->hpkp_enabled) {
    --- End diff --
    
    So it is not possible to enable HPKP globally then disable it on specific 
certificates? I think the expected behavior is for the certificate settings to 
always have precedence (if they are specified).  See 
[TS-2773](https://issues.apache.org/jira/browse/TS-2773) for 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to