Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/992#discussion_r78589196
--- Diff: iocore/net/test_certlookup.cc ---
@@ -88,7 +88,7 @@ REGRESSION_TEST(SSLCertificateLookup)(RegressionTest *t,
int /* atype ATS_UNUSED
// Basic hostname cases.
box.check(lookup.find("www.foo.com")->ctx == foo, "host lookup for
www.foo.com");
- box.check(lookup.find("www.bar.com")->ctx == all_com, "host lookup for
www.bar.com");
+ box.check(lookup.find("www.bar.com") == NULL, "www.bar.com won't match
*.com because we only match one level");
--- End diff --
Perhaps add some case bending to check that as well. Or is that a different
bug?
```
box.check(lookup.find("B.WilD.cOm")->ctx == wild, "wildcard lookup for
B.WilD.cOm");
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
