Leif Hedstrom created TS-4865:
---------------------------------
Summary: CID 1362785, CID 1362784: Error handling issues
(CHECKED_RETURN in server push example
Key: TS-4865
URL: https://issues.apache.org/jira/browse/TS-4865
Project: Traffic Server
Issue Type: Bug
Components: Plugins
Reporter: Leif Hedstrom
{code}
*** CID 1362785: Error handling issues (CHECKED_RETURN)
/example/server-push/server-push.c: 50 in should_push()
44
45 bool
46 should_push(TSHttpTxn txnp)
47 {
48 TSMBuffer mbuf;
49 TSMLoc hdr, url;
CID 1362785: Error handling issues (CHECKED_RETURN)
Calling "TSHttpTxnClientReqGet" without checking return value (as is done
elsewhere 45 out of 47 times).
50 TSHttpTxnClientReqGet(txnp, &mbuf, &hdr);
51 TSHttpHdrUrlGet(mbuf, hdr, &url);
52 int len;
53 TSUrlHttpQueryGet(mbuf, url, &len);
54 TSHandleMLocRelease(mbuf, hdr, url);
55 TSHandleMLocRelease(mbuf, TS_NULL_MLOC, hdr);
** CID 1362784: Error handling issues (CHECKED_RETURN)
/example/server-push/server-push.c: 51 in should_push()
________________________________________________________________________________________________________
*** CID 1362784: Error handling issues (CHECKED_RETURN)
/example/server-push/server-push.c: 51 in should_push()
45 bool
46 should_push(TSHttpTxn txnp)
47 {
48 TSMBuffer mbuf;
49 TSMLoc hdr, url;
50 TSHttpTxnClientReqGet(txnp, &mbuf, &hdr);
CID 1362784: Error handling issues (CHECKED_RETURN)
Calling "TSHttpHdrUrlGet" without checking return value (as is done
elsewhere 32 out of 36 times).
51 TSHttpHdrUrlGet(mbuf, hdr, &url);
52 int len;
53 TSUrlHttpQueryGet(mbuf, url, &len);
54 TSHandleMLocRelease(mbuf, hdr, url);
55 TSHandleMLocRelease(mbuf, TS_NULL_MLOC, hdr);
56 if (len > 0) {
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
