[
https://issues.apache.org/jira/browse/TS-4870?focusedWorklogId=29222&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29222
]
ASF GitHub Bot logged work on TS-4870:
--------------------------------------
Author: ASF GitHub Bot
Created on: 15/Sep/16 22:27
Start Date: 15/Sep/16 22:27
Worklog Time Spent: 10m
Work Description: Github user gtenev commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1028#discussion_r79075679
--- Diff: iocore/cache/P_CacheDisk.h ---
@@ -97,6 +97,7 @@ struct CacheDisk : public Continuation {
int num_errors;
int cleared;
bool read_only_p;
+ bool offline; /* flag marking cache disk offline (because of too many
failures or by the operator). */
--- End diff --
This is another review tests (per jpeach's request). "Start a review"
Issue Time Tracking
-------------------
Worklog Id: (was: 29222)
Time Spent: 50m (was: 40m)
> Storage can be marked offline multiple times which breaks related metrics
> -------------------------------------------------------------------------
>
> Key: TS-4870
> URL: https://issues.apache.org/jira/browse/TS-4870
> Project: Traffic Server
> Issue Type: Bug
> Components: Cache, Metrics
> Reporter: Gancho Tenev
> Assignee: Gancho Tenev
> Fix For: 7.1.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Let us say traffic server is running with 2 disks
> {code}
> $ cat etc/trafficserver/storage.config
> /dev/sdb
> /dev/sdc
> $ sudo fdisk -l|grep 'Disk /dev/sd[b|c]'
> Disk /dev/sdb: 134 MB, 134217728 bytes
> Disk /dev/sdc: 134 MB, 134217728 bytes
> {code}
> Let us see what happens when we mark the same disk 3 times in a raw
> ({{/dev/sdb}}) and check the {{proxy.node.cache.bytes_total}}.
> {code}
> # Initial cache size (when using both disks).
> $ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
> proxy.node.cache.bytes_total 268025856
> # Take 1st disk offline. Cache size changes as expected.
> $ sudo ./bin/traffic_ctl storage offline /dev/sdb
> $ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
> proxy.node.cache.bytes_total 134012928
> # Take same disk offline again. Not good!
> $ sudo ./bin/traffic_ctl storage offline /dev/sdb
> $ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
> proxy.node.cache.bytes_total 0
> # Take same disk offline again. Negative value.
> $ sudo ./bin/traffic_ctl storage offline /dev/sdb
> $ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
> proxy.node.cache.bytes_total -134012928
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
