[
https://issues.apache.org/jira/browse/TS-4888?focusedWorklogId=29639&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29639
]
ASF GitHub Bot logged work on TS-4888:
--------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/16 19:57
Start Date: 23/Sep/16 19:57
Worklog Time Spent: 10m
Work Description: GitHub user brkishore opened a pull request:
https://github.com/apache/trafficserver/pull/1044
TS-4888: Modified collapsed_frowarding plugin to return TSREMAP_DID_R…
TS-4888: This PR is to backport the fix on to 6.2.x branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brkishore/trafficserver TS-4888-BP-6.2.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1044.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1044
----
commit e62933db053755cc6edba1546a4d72bcff40eb90
Author: rb304g <rb3...@att.com>
Date: 2016-09-23T17:56:37Z
TS-4888: Modified collapsed_frowarding plugin to return TSREMAP_DID_REMAP.
----
Issue Time Tracking
-------------------
Worklog Id: (was: 29639)
Time Spent: 20m (was: 10m)
> collapsed_forwarding plugin returns TSREMAP_DID_REMAP though it did not
> perform remap
> -------------------------------------------------------------------------------------
>
> Key: TS-4888
> URL: https://issues.apache.org/jira/browse/TS-4888
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Affects Versions: 6.2.1, 7.1.0
> Reporter: Rajendra Kishore Bonumahanti
> Fix For: 6.2.1, 7.1.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Collapsed_forwarding plugin returns TSREMAP_DID_REMAP as a return value
> though it did not perform any remap. This causes ATS not to perform remap and
> makes the transaction failed due to DNS lookup error on "from url".
> For more details..
> Hi,
> I am testing collapsed_forwarding plugin
> (https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/collapsed_forwarding.en.html?highlight=collapsed_forwarding)
> via ATS 6.2.x branch.
> We observed an error "DNS error 2 for [testurl.com]" for cache-miss, when
> remap.config is configured with "collapsed_forwarding" to work alone as a
> remap plugin. We must modify TSRemapDoRemap() in the plugin to "return
> TSREMAP_NO_REMAP" to allow DNS lookup successful. It does not seem right for
> the plugin to do "return TSREMAP_NO_REMAP" when it did not.
> Can someone help me to understand how this plugin needs to be used? Or does
> it require the fix I mentioned above?
> Regards,
> Kishore
> == Sample remap.config entry and cach miss error when used
> "collapsed_forwarding" by itself == map http://testurl.com/
> http://origin.com/ @plugin=collapsed_forwarding.so @pparam=--delay=10
> @pparam=--retries=5
> I observed that during cache-miss, DNS query happens on the 'from' url
> (hostname) in the remap and it gets failed.
> ....
> [Sep 9 19:39:16.355] Server {0x2b170ea6c940} DEBUG: (dns) send query
> (qtype=1) for testurl.com to fd 43 [Sep 9 19:39:16.355] Server
> {0x2b170ea6c940} DEBUG: (dns) sent qname = testurl.com, id = 9287, nameserver
> = 1 [Sep 9 19:39:16.355] Server {0x2b170ea6c940} DEBUG: (dns) sent_one:
> failover_number for resolve 1 is 1 [Sep 9 19:39:16.628] Server
> {0x2b170ea6c940} DEBUG: (dns) received packet size = 52 [Sep 9 19:39:16.628]
> Server {0x2b170ea6c940} DEBUG: (dns) round-robin: nameserver 1 DNS respons
> code = 0 [Sep 9 19:39:16.628] Server {0x2b170ea6c940} DEBUG: (dns) received
> rcode = 2 [Sep 9 19:39:16.628] Server {0x2b170ea6c940} DEBUG: (dns) DNS
> error 2 for [testurl.com] [Sep 9 19:39:16.628] Server {0x2b170ea6c940}
> DEBUG: (dns) doing retry for testurl.com
> I further looked in to the code and found that it is due to return code from
> the plugin is TSREMAP_DID_REMAP in TSRemapDoRemap(). It makes ATS not to
> perform remap.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
