[
https://issues.apache.org/jira/browse/TS-4892?focusedWorklogId=29754&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29754
]
ASF GitHub Bot logged work on TS-4892:
--------------------------------------
Author: ASF GitHub Bot
Created on: 26/Sep/16 18:38
Start Date: 26/Sep/16 18:38
Worklog Time Spent: 10m
Work Description: GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/1049
TS-4892: Metric wrong for http.current_active_client_connections
Moved the m_active flag to ProxyClientSession. Added set_session_activate
and clear_session_activate methods which will only increment/decrement the
current_active_client_connections counter if the m_active flag changes value.
In all cases, the set_session_action is called from HttpSM when the request
header is successfully parsed.
For Http1, the clear_session_active is called when the transaction is
completed and when the session is closed.
For Http2, the clear_session_active is called when the number of active
streams goes to zero. The session may not necessarily be closing at this
point, but it is idle until another stream comes in.
We have been running with this patch in production
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-4892
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1049.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1049
----
commit cb096bcbb5132980f78bcfc1aecbfc5dac36405f
Author: Susan Hinrichs <[email protected]>
Date: 2016-09-26T18:32:20Z
TS-4892: Wrong metrix for
proxy.process.http.current_active_client_connections.
----
Issue Time Tracking
-------------------
Worklog Id: (was: 29754)
Time Spent: 10m
Remaining Estimate: 0h
> Wrong metrics for proxy.process.http.current_active_client_connections
> ----------------------------------------------------------------------
>
> Key: TS-4892
> URL: https://issues.apache.org/jira/browse/TS-4892
> Project: Traffic Server
> Issue Type: Bug
> Components: Metrics, Network
> Affects Versions: 7.0.0
> Reporter: Leif Hedstrom
> Assignee: Susan Hinrichs
> Priority: Blocker
> Fix For: 7.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> On Docs, running current 7.0.x branch, I'm seeing e.g.
> {code}
> proxy.process.http.current_client_connections 1
> proxy.process.http.current_active_client_connections 14994
> {code}
> This continues to grow indefinitely (but we crash pretty often, so resets).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
