Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1062#discussion_r81245130
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -356,8 +356,6 @@ Http2Stream::transaction_done()
if (closed) {
// Safe to initiate SSN_CLOSE if this is the last stream
- if (cross_thread_event)
- cross_thread_event->cancel();
// Schedule the destroy to occur after we unwind here. IF we call
directly, may delete with reference on the stack.
--- End diff --
This seems like a reasonable cleanup unless the earlier do_io_close could
cause the cross_thread_event to be set again. NULLing out cross_thread_event
earlier and adding an assert here would be reasonable.
However this fix doesn't seem to match the title. Canceling the event is
not going to cause the close to happen twice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
