Github user jacksontj commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1070#discussion_r81797531
--- Diff: proxy/http/HttpSM.cc ---
@@ -5310,9 +5310,6 @@ HttpSM::handle_post_failure()
tunnel.deallocate_buffers();
tunnel.reset();
// Server died
- vc_table.cleanup_entry(server_entry);
- server_entry = NULL;
- server_session = NULL;
--- End diff --
We should get a new session-- but to do the "is retryable" check, I need
access to the FD-- which is problematic if we release the session-- since it
get cleared/closed etc. With these lines removed it seems that we aren't
leaking sessions (from testing locally and in our staging env).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
