[
https://issues.apache.org/jira/browse/TS-4905?focusedWorklogId=30153&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30153
]
ASF GitHub Bot logged work on TS-4905:
--------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/16 01:34
Start Date: 05/Oct/16 01:34
Worklog Time Spent: 10m
Work Description: Github user masaori335 commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1075#discussion_r81887418
--- Diff: proxy/http/Http1ClientTransaction.cc ---
@@ -67,6 +67,7 @@ Http1ClientTransaction::transaction_done()
// If the parent session is not in the closed state, the destroy will
not occur.
if (parent) {
parent->destroy();
+ parent = NULL;
--- End diff --
Yeah, I'm not 100% sure this is right or not. But from the backtrace,
`destroy()` calls `free()`. In this case we need to set parent NULL.
```
#0 Http1ClientSession::free (this=0x60ae0001cc80) at
Http1ClientSession.cc:100
#1 0x00000000005c2386 in ProxyClientSession::handle_api_return
(this=0x60ae0001cc80, event=60000) at ProxyClientSession.cc:206
#2 0x00000000005c1f25 in ProxyClientSession::do_api_callout
(this=0x60ae0001cc80, id=TS_HTTP_SSN_CLOSE_HOOK) at ProxyClientSession.cc:177
#3 0x000000000065f787 in Http1ClientSession::destroy (this=0x60ae0001cc80)
at Http1ClientSession.cc:93
#4 0x0000000000664d20 in Http1ClientTransaction::transaction_done
(this=0x60ae0001cf60) at Http1ClientTransaction.cc:69
```
Issue Time Tracking
-------------------
Worklog Id: (was: 30153)
Time Spent: 50m (was: 40m)
> Crash when slow logging is enabled.
> -----------------------------------
>
> Key: TS-4905
> URL: https://issues.apache.org/jira/browse/TS-4905
> Project: Traffic Server
> Issue Type: Bug
> Reporter: James Peach
> Assignee: Masaori Koshiba
> Priority: Blocker
> Fix For: 7.1.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {noformat}
> Thread 14158, [ET_NET 5]:
> 0 0x00000000004ad342 crash_logger_invoke(int, siginfo_t*, void*) + 0x72
> 1 0x00002abccff59330 __restore_rt + (nil)
> 2 0x00000000004f166c ProxyClientTransaction::get_netvc() const + 0xc
> 3 0x00000000005a1712 HttpSM::update_stats() + 0x322
> 4 0x00000000005b4350 HttpSM::kill_this() + 0x380
> 5 0x00000000005b4ee8 HttpSM::main_handler(int, void*) + 0x108
> 6 0x00000000005f174d HttpTunnel::main_handler(int, void*) + 0x19d
> 7 0x00000000004ea7e2 PluginVC::process_write_side(bool) + 0x572
> 8 0x00000000004ed1b9 PluginVC::main_handler(int, void*) + 0x3a9
> 9 0x000000000076ced0 EThread::process_event(Event*, int) + 0x120
> 10 0x000000000076db8b EThread::execute() + 0x7fb
> 11 0x000000000076c95a spawn_thread_internal(void*) + 0x4a
> 12 0x00002abccff51184 start_thread + 0xc4
> 13 0x00002abcd0c8537d clone + 0x6d
> 14 0x0000000000000000 0x0 + 0x6d
> {noformat}
> In my build (close to master), this happens every time I enable slow logging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
