Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1075#discussion_r81987102
--- Diff: proxy/http/Http1ClientTransaction.cc ---
@@ -67,6 +67,7 @@ Http1ClientTransaction::transaction_done()
// If the parent session is not in the closed state, the destroy will
not occur.
if (parent) {
parent->destroy();
+ parent = NULL;
--- End diff --
Yes, destroy doesn't necessarily destroy. But from transaction_done(), the
client transaction is done with the parent session. So even if the parent is
still around, the client transaction should no longer be manipulating it.
The change looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
