Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1024#discussion_r82044347
--- Diff: iocore/net/P_SSLCertLookup.h ---
@@ -110,5 +109,5 @@ struct SSLCertLookup : public ConfigInfo {
void ticket_block_free(void *ptr);
ssl_ticket_key_block *ticket_block_alloc(unsigned count);
-
+ssl_ticket_key_block *ssl_create_ticket_key_block_buffer(char
*ticket_key_data, int ticket_key_len);
--- End diff --
Please use a consistent naming convention. We have``ticket_block_free()``,
``ticket_block_alloc()``, so consider ``ticket_block_create()`` or something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
