[
https://issues.apache.org/jira/browse/TS-4858?focusedWorklogId=30325&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30325
]
ASF GitHub Bot logged work on TS-4858:
--------------------------------------
Author: ASF GitHub Bot
Created on: 10/Oct/16 15:21
Start Date: 10/Oct/16 15:21
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1024#discussion_r82625369
--- Diff: iocore/net/SSLConfig.cc ---
@@ -243,6 +245,21 @@ SSLConfigParams::initialize()
ats_free(ssl_server_ca_cert_filename);
ats_free(CACertRelativePath);
+ REC_ReadConfigStringAlloc(ticket_key_filename,
"proxy.config.ssl.server.ticket_key.filename");
--- End diff --
The purpose of the newline is to break the code into "paragraphs" that make
it easier to read. Getting a value from config is distinct from using that
value for a particular purpose, so it deserves a new paragraph. Make it easy
for the reader.
Issue Time Tracking
-------------------
Worklog Id: (was: 30325)
Time Spent: 2h 10m (was: 2h)
> Global session ticket key block leaks.
> --------------------------------------
>
> Key: TS-4858
> URL: https://issues.apache.org/jira/browse/TS-4858
> Project: Traffic Server
> Issue Type: Bug
> Components: SSL
> Reporter: James Peach
> Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> From source inspection, ``global_default_keyblock`` is always assigned so it
> will leak on configuration reload.
> Have not reproduced this since I wasn't able to get SSL config reload to work
> :-(
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
