Github user jacksontj commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1095#discussion_r82878003
--- Diff: iocore/hostdb/test_RefCountCache.cc ---
@@ -135,8 +135,6 @@ testRefcounting()
cache->put(1, to_delete);
ret |= to_delete->refcount() != 1;
cache->erase(1);
- ret |= to_delete->refcount() != 0;
--- End diff --
Since the memory is actually getting freed we should figure out a way to
test that it was in fact deleted. An alternative is maybe to have it update a
global map of key -> bool for things that where deleted? then we could simply
do a get and ensure its not in the map. (something to replace the test instead
of dropping it. Or maybe a global atomic for number of active ExampleStruct
objects
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
