Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1088#discussion_r83084441
--- Diff: lib/ts/PriorityQueue.h ---
@@ -110,6 +110,12 @@ PriorityQueue<T, Comp>::pop()
return;
}
+ // SKH - I suspect this assignment is not preserving entry indices
correctly.
--- End diff --
Actually, I think that pop() is almost always safe since the last entry is
largest and the swaps in bubble_down will fix up the indices.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
