Github user kawaiirice commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/769#discussion_r83245499
--- Diff: proxy/http/HttpSM.cc ---
@@ -4726,6 +4727,44 @@ HttpSM::do_http_server_open(bool raw)
milestones[TS_MILESTONE_SERVER_FIRST_CONNECT] =
milestones[TS_MILESTONE_SERVER_CONNECT];
}
+ // Check for remap rule. If so, only apply ip_allow filter if it is
activated (ip_allow_flag set).
+ // Otherwise, if no remap rule is defined, apply the ip_allow filter.
+ if(!t_state.url_remap_success || (t_state.url_remap_success &&
t_state.url_map.getMapping()->ip_allow_flag)) {
--- End diff --
Is checking `acl_record->isEmpty()` right after finding a match for the
server ip considered too late?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
