[
https://issues.apache.org/jira/browse/TS-4968?focusedWorklogId=30642&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30642
]
ASF GitHub Bot logged work on TS-4968:
--------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/16 15:31
Start Date: 14/Oct/16 15:31
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1105#discussion_r83445904
--- Diff: proxy/http/HttpConfig.cc ---
@@ -1224,12 +1224,16 @@ HttpConfig::reconfigure()
params->oride.connect_attempts_max_retries =
m_master.oride.connect_attempts_max_retries;
params->oride.connect_attempts_max_retries_dead_server =
m_master.oride.connect_attempts_max_retries_dead_server;
- params->oride.connect_attempts_rr_retries =
m_master.oride.connect_attempts_rr_retries;
- params->oride.connect_attempts_timeout =
m_master.oride.connect_attempts_timeout;
- params->oride.post_connect_attempts_timeout =
m_master.oride.post_connect_attempts_timeout;
- params->oride.parent_connect_attempts =
m_master.oride.parent_connect_attempts;
- params->per_parent_connect_attempts =
m_master.per_parent_connect_attempts;
- params->parent_connect_timeout =
m_master.parent_connect_timeout;
+ if (m_master.oride.connect_attempts_rr_retries >=
params->oride.connect_attempts_max_retries) {
+ Warning("connect_attempts_rr_retries is greater than
connect_attempts_max_retries, this means requests will never redispatch "
--- End diff --
Print the actual values here. AFAIK Traffic Server docs don't use the term
``real``, maybe just say ``will never be retried``.
Issue Time Tracking
-------------------
Worklog Id: (was: 30642)
Time Spent: 40m (was: 0.5h)
> Log a warning if connect_attempts_rr_retries is >=
> connect_attempts_max_retries
> -------------------------------------------------------------------------------
>
> Key: TS-4968
> URL: https://issues.apache.org/jira/browse/TS-4968
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
> Reporter: Thomas Jackson
> Time Spent: 40m
> Remaining Estimate: 0h
>
> If connect_attempts_rr_retries >= connect_attempts_max_retries requests going
> to an RR DNS record will never be redispatched. To make it a bit more
> obvious-- I think we should log a warning when we load the configs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
